kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ale...@apache.org
Subject kudu git commit: [util] updated output from TryRunLsof()
Date Thu, 11 May 2017 02:21:30 GMT
Repository: kudu
Updated Branches:
  refs/heads/master 87ddf0ae2 -> ae7cfa04a


[util] updated output from TryRunLsof()

TryRunLsof() should not conclude it's called because of an error
binding to the specified address: in some use-cases it might not be the
case.  The output is updated to remove the statement about a failure to
bind to the specified address, leaving just the output from lsof.

This is a pure cosmetic fix to improve error message readability
in the context of KUDU-2005.

Change-Id: I1ff0d28f631c7f392420040b132f7542f08b74d6
Reviewed-on: http://gerrit.cloudera.org:8080/6852
Reviewed-by: Adar Dembo <adar@cloudera.com>
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/ae7cfa04
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/ae7cfa04
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/ae7cfa04

Branch: refs/heads/master
Commit: ae7cfa04a64e8f9a494db36c4f20e11cea311845
Parents: 87ddf0a
Author: Alexey Serbin <aserbin@cloudera.com>
Authored: Wed May 10 18:28:14 2017 -0700
Committer: Alexey Serbin <aserbin@cloudera.com>
Committed: Thu May 11 02:20:07 2017 +0000

----------------------------------------------------------------------
 src/kudu/util/net/net_util.cc | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/ae7cfa04/src/kudu/util/net/net_util.cc
----------------------------------------------------------------------
diff --git a/src/kudu/util/net/net_util.cc b/src/kudu/util/net/net_util.cc
index d67375c..64a5d86 100644
--- a/src/kudu/util/net/net_util.cc
+++ b/src/kudu/util/net/net_util.cc
@@ -289,10 +289,9 @@ void TryRunLsof(const Sockaddr& addr, vector<string>* log)
{
       "done",
       addr.port());
 #endif // defined(__APPLE__)
-
-  LOG_STRING(WARNING, log) << "Failed to bind to " << addr.ToString() <<
". "
-                           << "Trying to use lsof to find any processes listening "
-                           << "on the same port:";
+  LOG_STRING(WARNING, log)
+      << "Trying to use lsof to find any processes listening on "
+      << addr.ToString();
   LOG_STRING(INFO, log) << "$ " << cmd;
   vector<string> argv = { "bash", "-c", cmd };
   string results;


Mime
View raw message