kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject [1/2] kudu git commit: [java] Remove double brackets from wrapper script
Date Fri, 11 Aug 2017 21:49:49 GMT
Repository: kudu
Updated Branches:
  refs/heads/master 71454b69a -> ce6ecc5a5


[java] Remove double brackets from wrapper script

When running on Jenkins the gradle wrapper script causes:
`[[: not found`

This is because the wrapper script is a shell script
and not a bash script. In that case [[ is not built in.

Change-Id: I839c47bbef8bf901047b9379be958f4cebbd406e
Reviewed-on: http://gerrit.cloudera.org:8080/7655
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <todd@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/12084b3b
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/12084b3b
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/12084b3b

Branch: refs/heads/master
Commit: 12084b3b9fad4019ab5a29b039d74844d2224368
Parents: 71454b6
Author: Grant Henke <granthenke@gmail.com>
Authored: Thu Aug 10 22:32:40 2017 -0500
Committer: Todd Lipcon <todd@apache.org>
Committed: Fri Aug 11 05:43:01 2017 +0000

----------------------------------------------------------------------
 java/gradle/wrapper.gradle | 2 +-
 java/gradlew               | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/12084b3b/java/gradle/wrapper.gradle
----------------------------------------------------------------------
diff --git a/java/gradle/wrapper.gradle b/java/gradle/wrapper.gradle
index 4efab86..1504308 100644
--- a/java/gradle/wrapper.gradle
+++ b/java/gradle/wrapper.gradle
@@ -35,7 +35,7 @@ task bootstrapWrapper() {
 
 
     def boostrapString = """
-      if [[ ! -e $wrapperJarPath ]]; then
+      if [ ! -e $wrapperJarPath ]; then
          curl -o $wrapperJarPath $wrapperJarUrl
       fi
       """.stripIndent()

http://git-wip-us.apache.org/repos/asf/kudu/blob/12084b3b/java/gradlew
----------------------------------------------------------------------
diff --git a/java/gradlew b/java/gradlew
index 93678fd..eae4091 100755
--- a/java/gradlew
+++ b/java/gradlew
@@ -65,7 +65,7 @@ case "`uname`" in
 esac
 
 
-if [[ ! -e $APP_HOME/gradle/wrapper/gradle-wrapper.jar ]]; then
+if [ ! -e $APP_HOME/gradle/wrapper/gradle-wrapper.jar ]; then
    curl -o $APP_HOME/gradle/wrapper/gradle-wrapper.jar https://raw.githubusercontent.com/gradle/gradle/v4.0.2/gradle/wrapper/gradle-wrapper.jar
 fi
 


Mime
View raw message