kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject kudu git commit: mini-cluster: condition on NO_TESTS=0
Date Tue, 03 Oct 2017 21:08:20 GMT
Repository: kudu
Updated Branches:
  refs/heads/master 350c8a79c -> 4c7d8e040


mini-cluster: condition on NO_TESTS=0

This module will be incorporated into the kudu CLI in the near future, but
for now this patch fixes builds that set NO_TESTS=1.

Our precommit builds don't disable tests, so I tested this by running a
local build with NO_TESTS=1. Without this patch, the build failed while
linking libmini-cluster.so. With it, the build passes.

Change-Id: I195b3ed5ed50dfbe7afb3004182bf02a3bcda31a
Reviewed-on: http://gerrit.cloudera.org:8080/8199
Tested-by: Adar Dembo <adar@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <aserbin@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/4c7d8e04
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/4c7d8e04
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/4c7d8e04

Branch: refs/heads/master
Commit: 4c7d8e0402ff9a226b5b7c8f4b3c5641829602ef
Parents: 350c8a7
Author: Adar Dembo <adar@cloudera.com>
Authored: Tue Oct 3 12:29:39 2017 -0700
Committer: Adar Dembo <adar@cloudera.com>
Committed: Tue Oct 3 21:08:03 2017 +0000

----------------------------------------------------------------------
 src/kudu/mini-cluster/CMakeLists.txt | 5 +++++
 1 file changed, 5 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/4c7d8e04/src/kudu/mini-cluster/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/src/kudu/mini-cluster/CMakeLists.txt b/src/kudu/mini-cluster/CMakeLists.txt
index e43d10b..6b074ed 100644
--- a/src/kudu/mini-cluster/CMakeLists.txt
+++ b/src/kudu/mini-cluster/CMakeLists.txt
@@ -15,6 +15,11 @@
 # specific language governing permissions and limitations
 # under the License.
 
+# Everything in this module is test-related.
+if (NO_TESTS)
+  return()
+endif()
+
 set(MINI_CLUSTER_SRCS
   external_mini_cluster.cc
   internal_mini_cluster.cc


Mime
View raw message