kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject kudu git commit: KUDU-2478: restore python 2.6 compatibility
Date Wed, 20 Jun 2018 20:50:21 GMT
Repository: kudu
Updated Branches:
  refs/heads/branch-1.7.x 1033eba46 -> 8d7221570


KUDU-2478: restore python 2.6 compatibility

Another day, another unpinned dependency breaks compatibility with Python
2.6. This time it was due to updates to pytest and pytest-timeout. I pinned
them to the last versions before 2.6 compatibility became unsupported.

I tested by running through the Python steps in build-and-test.sh on a
CentOS 6.6 machine.

Change-Id: I5869f3105c14ecb10023565f353664fb20720886
Reviewed-on: http://gerrit.cloudera.org:8080/10774
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <adar@cloudera.com>
(cherry picked from commit 61fb6dc30a59047aee097ce4e8f82bf6d268effe)
Reviewed-on: http://gerrit.cloudera.org:8080/10775
Reviewed-by: Andrew Wong <awong@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/8d722157
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/8d722157
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/8d722157

Branch: refs/heads/branch-1.7.x
Commit: 8d722157030064b1ad5152513a5ed73da22edd6d
Parents: 1033eba
Author: Adar Dembo <adar@cloudera.com>
Authored: Wed Jun 20 11:35:44 2018 -0700
Committer: Adar Dembo <adar@cloudera.com>
Committed: Wed Jun 20 20:50:05 2018 +0000

----------------------------------------------------------------------
 python/requirements.txt | 8 ++++++--
 python/setup.py         | 7 ++++++-
 2 files changed, 12 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/8d722157/python/requirements.txt
----------------------------------------------------------------------
diff --git a/python/requirements.txt b/python/requirements.txt
index a4f3cb0..f7013a9 100644
--- a/python/requirements.txt
+++ b/python/requirements.txt
@@ -1,5 +1,9 @@
-pytest
-cython == 0.26.1
+# pytest 3.3 dropped support for python 2.6.
+#
+# See https://docs.pytest.org/en/latest/changelog.html#id164 for more details.
+pytest >=2.8,<3.3
+
+cython ==0.26.1
 six
 unittest2
 pytz

http://git-wip-us.apache.org/repos/asf/kudu/blob/8d722157/python/setup.py
----------------------------------------------------------------------
diff --git a/python/setup.py b/python/setup.py
index 547bc0d..dbf87be 100644
--- a/python/setup.py
+++ b/python/setup.py
@@ -189,7 +189,12 @@ setup(
         'build_ext': build_ext
     },
     setup_requires=['pytest-runner'],
-    tests_require=['pytest >= 2.8', 'pytest-timeout >= 1.1.0'],
+
+    # pytest 3.3 and pytest-timeout 1.2.1 dropped support for python 2.6.
+    #
+    # See https://docs.pytest.org/en/latest/changelog.html#id164 and
+    # https://pypi.org/project/pytest-timeout/#id5 for more details.
+    tests_require=['pytest >=2.8,<3.3', 'pytest-timeout >=1.1.0,<1.2.1'],
     install_requires=['cython >= 0.21', 'pytz', 'six'],
     description=DESCRIPTION,
     long_description=LONG_DESCRIPTION,


Mime
View raw message