kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From granthe...@apache.org
Subject [kudu] 01/02: [doxygen] fix KuduScanTokenBuilder::SetDiffScan (take two)
Date Thu, 11 Jul 2019 13:00:16 GMT
This is an automated email from the ASF dual-hosted git repository.

granthenke pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit 26bd0fdc4ba74d130f709837e33eb258633c51ce
Author: Alexey Serbin <alexey@apache.org>
AuthorDate: Wed Jul 10 16:49:19 2019 -0700

    [doxygen] fix KuduScanTokenBuilder::SetDiffScan (take two)
    
    Since both {KuduScanner,KuduScanTokenBuilder}::SetDiffScan() are both
    under the same PRIVATE_API conditional, it's possible to use the
    @copydoc to avoid the duplication of the description.
    
    This is a follow-up to 0b4948ea3.
    
    Change-Id: I2de45bf62bd8ef240b0d0e0cd3f887ef3d40cd04
    Reviewed-on: http://gerrit.cloudera.org:8080/13841
    Tested-by: Kudu Jenkins
    Reviewed-by: Grant Henke <granthenke@apache.org>
---
 src/kudu/client/client.h | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)

diff --git a/src/kudu/client/client.h b/src/kudu/client/client.h
index 20c3440..fdc408d 100644
--- a/src/kudu/client/client.h
+++ b/src/kudu/client/client.h
@@ -2432,24 +2432,9 @@ class KUDU_EXPORT KuduScanTokenBuilder {
   Status SetSnapshotRaw(uint64_t snapshot_timestamp) WARN_UNUSED_RESULT;
 
   /// @cond PRIVATE_API
-
-  /// Set the start and end timestamp for a diff scan. The timestamps should be
-  /// encoded HT timestamps.
-  ///
-  /// Additionally sets any other scan properties required by diff scans.
-  ///
-  /// Private API.
-  ///
-  /// @param [in] start_timestamp
-  ///   Start timestamp to set in raw encoded form
-  ///   (i.e. as returned by a previous call to a server).
-  /// @param [in] end_timestamp
-  ///   End timestamp to set in raw encoded form
-  ///   (i.e. as returned by a previous call to a server).
-  /// @return Operation result status.
+  /// @copydoc KuduScanner::SetDiffScan
   Status SetDiffScan(uint64_t start_timestamp, uint64_t end_timestamp)
       WARN_UNUSED_RESULT KUDU_NO_EXPORT;
-
   /// @endcond
 
   /// @copydoc KuduScanner::SetTimeoutMillis


Mime
View raw message