kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From granthe...@apache.org
Subject [kudu] 02/04: Remove experimental tags from NVM block cache gflags
Date Fri, 12 Jul 2019 18:59:15 GMT
This is an automated email from the ASF dual-hosted git repository.

granthenke pushed a commit to branch branch-1.10.x
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit bc0aad22688e325287b644bff94e17d3bec70d05
Author: Adar Dembo <adar@cloudera.com>
AuthorDate: Tue Jul 9 15:47:37 2019 -0700

    Remove experimental tags from NVM block cache gflags
    
    The block cache has supported non-volatile memory for almost four years
    now, though one needed to configure some experimental gflags in order to
    use it. The implementation was recently changed to use the newer memkind
    library and, in the process, underwent additional testing on NVM hardware.
    As such, I think it's time to remove the experimental tags to communicate to
    users that the underlying code is supported upstream.
    
    Note: I'm not marking them as 'stable' so that we retain the flexibility to
    modify the configuration surface itself, if we find we need that.
    
    Change-Id: Ie6b58118116ecc11b2eaa5cec4a9e72c29ac27f8
    Reviewed-on: http://gerrit.cloudera.org:8080/13830
    Reviewed-by: Greg Solovyev <gsolovyev@cloudera.com>
    Reviewed-by: Andrew Wong <awong@cloudera.com>
    Tested-by: Kudu Jenkins
    (cherry picked from commit daf2572ad107bc50bb8a4e534a5e1414aa71bbe6)
    Reviewed-on: http://gerrit.cloudera.org:8080/13838
---
 src/kudu/cfile/block_cache.cc | 3 +--
 src/kudu/util/nvm_cache.cc    | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/kudu/cfile/block_cache.cc b/src/kudu/cfile/block_cache.cc
index ff17524..5ea8316 100644
--- a/src/kudu/cfile/block_cache.cc
+++ b/src/kudu/cfile/block_cache.cc
@@ -54,8 +54,7 @@ DEFINE_string(block_cache_type, "DRAM",
               "Which type of block cache to use for caching data. "
               "Valid choices are 'DRAM' or 'NVM'. DRAM, the default, "
               "caches data in regular memory. 'NVM' caches data "
-              "in a memory-mapped file using the NVML library.");
-TAG_FLAG(block_cache_type, experimental);
+              "in a memory-mapped file using the memkind library.");
 
 using strings::Substitute;
 
diff --git a/src/kudu/util/nvm_cache.cc b/src/kudu/util/nvm_cache.cc
index 55adffd..320048b 100644
--- a/src/kudu/util/nvm_cache.cc
+++ b/src/kudu/util/nvm_cache.cc
@@ -59,7 +59,6 @@ DECLARE_bool(cache_force_single_shard);
 DEFINE_string(nvm_cache_path, "/pmem",
               "The path at which the NVM cache will try to allocate its memory. "
               "This can be a tmpfs or ramfs for testing purposes.");
-TAG_FLAG(nvm_cache_path, experimental);
 
 DEFINE_int32(nvm_cache_allocation_retry_count, 10,
              "The number of times that the NVM cache will retry attempts to allocate "


Mime
View raw message