kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From granthe...@apache.org
Subject [kudu] 01/02: [build] Fix IWYU dependencies
Date Thu, 09 Jan 2020 20:04:35 GMT
This is an automated email from the ASF dual-hosted git repository.

granthenke pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit bc013dfb65128943b9a49473d9d7b969d949a09b
Author: Grant Henke <granthenke@apache.org>
AuthorDate: Thu Jan 9 10:15:52 2020 -0800

    [build] Fix IWYU dependencies
    
    IWYU is failing with a missing `version_defines.h`. This patch
    fixes the dependency chain by adding `gen_version_info`
    to the generated-headers target. This ensures it’s run
    for the iwyu and tidy targets.
    
    Change-Id: I2521a1d54b695971afbe445729e746beeb5db595
    Reviewed-on: http://gerrit.cloudera.org:8080/14995
    Reviewed-by: Alexey Serbin <aserbin@cloudera.com>
    Tested-by: Kudu Jenkins
---
 CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 07bf648..0b355c1 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1377,7 +1377,7 @@ endif (UNIX)
 ############################################################
 if (UNIX)
   add_custom_target(generated-headers
-    DEPENDS pb-gen krpc-gen hms_thrift sentry_thrift)
+    DEPENDS pb-gen krpc-gen hms_thrift sentry_thrift gen_version_info)
 endif (UNIX)
 
 ############################################################


Mime
View raw message