kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "liyang (JIRA)" <>
Subject [jira] [Commented] (KYLIN-1122) Kylin support detail data query from fact table
Date Sun, 10 Jan 2016 10:49:40 GMT


liyang commented on KYLIN-1122:

My comments on the "0001-KYLIN-1122-Kylin-support-detail-data-query-from-fact-new-impl-under-refactoring-2.x-staging.patch".

1) Should not change BasicMeasureType.validate() and FunctionDesc.FUNC_RAW. All changes should
go inside RawXXX classes ideally. The raw measure type should be kinda encapsulated all in
its own package.
2) Call Tuple.setDimensionValue() instead of Tuple.setMeasureValue() to fill in tuple values.
The raw columns are indeed dimensions persisted in a measure container.
3) I expected influenceCapabilityCheck()  &  adjustSqlDigest() are used to loop in RawMeasureType
during storage processing. However in the patch, a lot of the stuff happened in OLAPEnumerator.hackNoGroupByAggregation().
4) Need unit test on RawSerializer & RawAggregator.
5) Need integration test on the whole thing.

How about this. Let's fork a new branch "KYLIN-1122" (off 2.x-staging) to collaborate and
move forward. Xiaoyu can fix 1) 2) 4) and me (or Shaofeng or Hongbin) can try 3) 5). When
we are happy with the work on the branch, the whole thing then merge back to 2.x-staging.

The 1.x-staging patch looks quite different, does not contain the RawMeasureType, RawSerializer
etc... guess it will be updated once the 2.x-staging patch is stable right? I hope the two
versions are very similar.

> Kylin support detail data query from fact table
> -----------------------------------------------
>                 Key: KYLIN-1122
>                 URL:
>             Project: Kylin
>          Issue Type: New Feature
>          Components: Query Engine
>    Affects Versions: v1.2
>            Reporter: Xiaoyu Wang
>            Assignee: liyang
>             Fix For: v2.0, v1.3
>         Attachments: 0001-KYLIN-1122-Kylin-support-detail-data-query-from-fact(2.x-staging).patch,
0001-KYLIN-1122-Kylin-support-detail-data-query-from-fact(update-v2-1.x-staging).patch, 0001-KYLIN-1122-Kylin-support-detail-data-query-from-fact-new-impl-under-refactoring-2.x-staging.patch
> Now Kylin does not support query correct detail rows from fact table like:
> select column1,column2,column3 from fact_table
> The jira KYLIN-1075 add the "SUM" function on the measure column if defined.
> But only the column number type is support.
> I change some code to support this issue:
> Add a "VALUE" measure function : the same value and datatype in the input and output
of this function.
> If you want to query detail data from fact table
> *require*:
> 1.Configure the column which not dimensions to "VALUE" or "SUM" measure.(If not configure
measure function in the column will get NULL value)
> 2.The source table must has an unique value column and configure it as dimension.
> If you have the better solution please comment here.

This message was sent by Atlassian JIRA

View raw message