kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3669) Add log to GTStreamAggregateScanner
Date Wed, 21 Nov 2018 04:17:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694204#comment-16694204
] 

ASF GitHub Bot commented on KYLIN-3669:
---------------------------------------

shaofengshi closed pull request #352: KYLIN-3669, add log to indicate the case when using
"GTStreamAggregateScanner".
URL: https://github.com/apache/kylin/pull/352
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SegmentCubeTupleIterator.java
b/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SegmentCubeTupleIterator.java
index 629c02563b..028d105a17 100644
--- a/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SegmentCubeTupleIterator.java
+++ b/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SegmentCubeTupleIterator.java
@@ -92,6 +92,7 @@ public SegmentCubeTupleIterator(CubeSegmentScanner scanner, Cuboid cuboid,
Set<T
 
         boolean hasMultiplePartitions = records instanceof SortMergedPartitionResultIterator;
         if (hasMultiplePartitions && context.isStreamAggregateEnabled()) {
+            logger.info("Using GTStreamAggregateScanner to pre-aggregate storage partition.");
             // input records are ordered, leverage stream aggregator to produce possibly
fewer records
             IGTScanner inputScanner = new IGTScanner() {
                 public GTInfo getInfo() {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add log to GTStreamAggregateScanner
> -----------------------------------
>
>                 Key: KYLIN-3669
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3669
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Query Engine
>            Reporter: Jiatao Tao
>            Assignee: Jiatao Tao
>            Priority: Trivial
>
> There's no log printing in GTStreamAggregateScanner, and you know nothing about whether
you go to this path or not, it's pretty unfriendly for trouble shooting.
> Code in _SegmentCubeTupleIterator_.
> {code:java}
> boolean hasMultiplePartitions = records instanceof SortMergedPartitionResultIterator;
> if (hasMultiplePartitions && context.isStreamAggregateEnabled()) {
>     ...
>     // input records are ordered, leverage stream aggregator to produce possibly fewer
records
>     try (GTStreamAggregateScanner aggregator = new GTStreamAggregateScanner(inputScanner,
scanRequest)) {
>         result = aggregator.valuesIterator(gtDimsIdx, gtMetricsIdx);
>     } catch (IOException ioe) {
>         // implementation of close method of anonymous IGTScanner is empty, no way throw
exception
>         throw new IllegalStateException("IOException is not expected here.", ioe);
>     }
>     return result;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message