kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [kylin] kyotoYaho commented on a change in pull request #579: KYLIN-3926 set sourceRecordCount when updating statistics
Date Wed, 10 Apr 2019 14:21:11 GMT
kyotoYaho commented on a change in pull request #579: KYLIN-3926 set sourceRecordCount when
updating statistics
URL: https://github.com/apache/kylin/pull/579#discussion_r273986563
 
 

 ##########
 File path: engine-mr/src/main/java/org/apache/kylin/engine/mr/common/CubeStatsWriter.java
 ##########
 @@ -43,6 +43,11 @@ public static void writeCuboidStatistics(Configuration conf, Path outputPath,
//
         writeCuboidStatistics(conf, outputPath, cuboidHLLMap, samplingPercentage, 0, 0, 0);
     }
 
+    public static void writeCuboidStatistics(Configuration conf, Path outputPath, //
+            Map<Long, HLLCounter> cuboidHLLMap, int samplingPercentage, long sourceRecordCoun)
throws IOException {
+        writeCuboidStatistics(conf, outputPath, cuboidHLLMap, samplingPercentage, 0, 0, sourceRecordCoun);
 
 Review comment:
   Just copied from the existing parameter name. However, it's better to change it from sourceRecordCoun
to sourceRecordCount.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message