kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [kylin] kyotoYaho commented on a change in pull request #579: KYLIN-3926 set sourceRecordCount when updating statistics
Date Wed, 10 Apr 2019 14:24:08 GMT
kyotoYaho commented on a change in pull request #579: KYLIN-3926 set sourceRecordCount when
updating statistics
URL: https://github.com/apache/kylin/pull/579#discussion_r273988285
 
 

 ##########
 File path: engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MergeStatisticsStep.java
 ##########
 @@ -120,8 +129,11 @@ protected ExecuteResult doWork(ExecutableContext context) throws ExecuteExceptio
                         tempFile.delete();
                 }
             }
+            sourceRecordCount *= effectiveTimeRange == 0 ? 0 : newSegment.getTSRange().duration()
/ effectiveTimeRange;
 
 Review comment:
   It's not necessary to do so. Row count itself is an approximate one. And this data is set
to long type at other place and we shouldn't break the compatibility.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message