kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3968) Customized precision doesn't work in web
Date Sun, 28 Apr 2019 11:02:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827924#comment-16827924
] 

ASF GitHub Bot commented on KYLIN-3968:
---------------------------------------

majic31 commented on pull request #623: KYLIN-3968 Customized precision doesn't work in web
URL: https://github.com/apache/kylin/pull/623
 
 
    In the cubeMeasures.js, It will withdraw precision and scale by using Regular Expression.
The scale parameter is ok, but precision use the magic number 19.
   So we fixed it, In cubeMeasures.js, around line 469:
   
   “var precision = 19;”  --> "var precision = returnValue[2] || 0;"
   
   and we test ok including building cube and querying when the column is decimal(38,18).

 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Customized precision doesn't work in web
> ----------------------------------------
>
>                 Key: KYLIN-3968
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3968
>             Project: Kylin
>          Issue Type: Bug
>          Components: Web 
>            Reporter: Jack
>            Priority: Minor
>             Fix For: v2.6.2
>
>
> In the cubeMeasures.js, It will withdraw precision and scale by using Regular Expression.
The scale parameter is ok, but precision use the magic number 19.
> So we fixed it, In cubeMeasures.js, around line 469:
> “var precision = 19;”  --> "var precision = returnValue[2] || 0;"
> and we test ok including building cube and querying when the column is decimal(38,18).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message