From issues-return-25891-apmail-kylin-issues-archive=kylin.apache.org@kylin.apache.org Wed Apr 10 14:26:14 2019 Return-Path: X-Original-To: apmail-kylin-issues-archive@minotaur.apache.org Delivered-To: apmail-kylin-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id C20F7189E5 for ; Wed, 10 Apr 2019 14:26:13 +0000 (UTC) Received: (qmail 64954 invoked by uid 500); 10 Apr 2019 14:26:12 -0000 Delivered-To: apmail-kylin-issues-archive@kylin.apache.org Received: (qmail 64922 invoked by uid 500); 10 Apr 2019 14:26:12 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 64907 invoked by uid 99); 10 Apr 2019 14:26:12 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Apr 2019 14:26:12 +0000 From: GitBox To: issues@kylin.apache.org Subject: [GitHub] [kylin] kyotoYaho commented on a change in pull request #579: KYLIN-3926 set sourceRecordCount when updating statistics Message-ID: <155490637307.21639.422128300115551559.gitbox@gitbox.apache.org> Date: Wed, 10 Apr 2019 14:26:13 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit kyotoYaho commented on a change in pull request #579: KYLIN-3926 set sourceRecordCount when updating statistics URL: https://github.com/apache/kylin/pull/579#discussion_r273989472 ########## File path: engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MergeStatisticsStep.java ########## @@ -120,8 +129,11 @@ protected ExecuteResult doWork(ExecutableContext context) throws ExecuteExceptio tempFile.delete(); } } + sourceRecordCount *= effectiveTimeRange == 0 ? 0 : newSegment.getTSRange().duration() / effectiveTimeRange; Review comment: For details, please check http://issues.apache.org/jira/browse/KYLIN-3453 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services