kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [kylin] shaofengshi commented on issue #1128: KYLIN-4389 Change Flink jar dependence from compile to provided
Date Mon, 02 Mar 2020 02:06:51 GMT
shaofengshi commented on issue #1128: KYLIN-4389 Change Flink jar dependence from compile to
provided
URL: https://github.com/apache/kylin/pull/1128#issuecomment-593186130
 
 
   Hi Harvey, the code change looks good to me; The only thing is, this PR contains 3 commits,
and 2 of them are merge commits. As you know, merge commits are not acceptable. Could you
please rebase and squash these commits as one? If you don't know how to do that, just feel
free to let me know.
   
   BTW, are you modifying code on master branch? If so, suggest you create another branch
and then commit changes there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message