kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "cpugputpu (Jira)" <>
Subject [jira] [Updated] (KYLIN-4397) Use newLinkedHashMap in
Date Mon, 02 Mar 2020 14:01:00 GMT


cpugputpu updated KYLIN-4397:
    Summary: Use newLinkedHashMap in  (was: Use newLinkedHashMap in stream-coordinator/src/main/java/org/apache/kylin/stream/coordinator/assign/

> Use newLinkedHashMap in
> -------------------------------------------
>                 Key: KYLIN-4397
>                 URL:
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: cpugputpu
>            Priority: Minor
> The tests in can
fail and the failure is presented as follow.
> _java.lang.AssertionError: expected:<2> but was:<1>_
> _at
when executing _assertEquals(2, rsAssignment.size());_
> The root cause of this failure is when executing _Map<Integer, Map<String, List<Partition>>>
result = assigner.reBalancePlan(rsList, cubes, existingAssignments);_ it will iterate over
a HashMap. The stack trace is here:
> _java.util.HashMap$EntrySet.iterator(
> The specification about HashMap says that "this class makes no guarantees as to the order
of the map; in particular, it does not guarantee that the order will remain constant over
time". The documentation is here for your reference: [|][l|]
> The fix is to use LinkedHashMap instead of HashMap when initializing a Map. In this way,
the non-deterministic behaviour is eliminated and the test will not suffer from the failure
again. The code will be more stable.

This message was sent by Atlassian Jira

View raw message