kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [kylin] xiacongling commented on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled
Date Wed, 01 Apr 2020 08:52:05 GMT
xiacongling commented on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect
long time when lazy query enabled
URL: https://github.com/apache/kylin/pull/1167#issuecomment-607122057
 
 
   Never mind, @kyotoYaho ! I think the problem is that conditions are lost in finally block.
We can either rebuild the conditions or use the cached value.
   
   - The former solution will add complicated condition checks in the final block. These checks
are difficult to understand and test, and may be buggy in the future when features are addd
or improvements are made. 
   - The latter will visit the cache one more time and will reduce the query performance.
   
   Using "try .. finally" is more elegant, but some code refactoring is needed to keep it
clean, I think. To get out of the dilemma, we can treat this PR as a quick bug-fix, and discuss
the refactoring in another issue. 
   
   I will revert the commit. Thanks for the review!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message