libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tomaz Muraus (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LIBCLOUD-492) In ec2 driver delete_key_pair accept key name, not KeyPair object
Date Tue, 14 Jan 2014 14:07:50 GMT

    [ https://issues.apache.org/jira/browse/LIBCLOUD-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870742#comment-13870742
] 

Tomaz Muraus commented on LIBCLOUD-492:
---------------------------------------

Good catch, thanks!

I've made two minor changes and merged your patch into trunk:

* Removed docstring from the delete_key_pair method. This docstring is redundant since this
method is already documented on the parent class.
* Fixed a lint issue

> In ec2 driver delete_key_pair accept key name, not KeyPair object
> -----------------------------------------------------------------
>
>                 Key: LIBCLOUD-492
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-492
>             Project: Libcloud
>          Issue Type: Bug
>            Reporter: Oleg Suharev
>         Attachments: LIBCLOUD-492.patch
>
>
> In EC2 driver delete_key_pair work only if send key_pair as string, but in openstack
and cloudstack driver this method wait KeyPair object
> {code}
>     def delete_key_pair(self, key_pair):
>         params = {
>             'Action': 'DeleteKeyPair',
>             'KeyName': key_pair
>         }
>         result = self.connection.request(self.path, params=params).object
>         element = findtext(element=result, xpath='return',
>                            namespace=NAMESPACE)
>         return element == 'true'
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message