libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From to...@apache.org
Subject git commit: [LIBCLOUD-569] Removing the overloaded constructor from the rimuhosting base class.
Date Tue, 03 Jun 2014 20:21:57 GMT
Repository: libcloud
Updated Branches:
  refs/heads/trunk e42e87862 -> dff5c5314


[LIBCLOUD-569] Removing the overloaded constructor from the rimuhosting base class.

Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress
function resuuulting in a MalformedResponseError. All functionality in overloaded constructor
already existed in the base clase.

Closes #303

Signed-off-by: Tomaz Muraus <tomaz@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/dff5c531
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/dff5c531
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/dff5c531

Branch: refs/heads/trunk
Commit: dff5c5314790968fa1bdebf66d8b83dae4e64201
Parents: e42e878
Author: amastracci <amastracci@pertino.com>
Authored: Sun Jun 1 12:22:28 2014 -0700
Committer: Tomaz Muraus <tomaz@apache.org>
Committed: Tue Jun 3 22:19:45 2014 +0200

----------------------------------------------------------------------
 CHANGES.rst                             |  5 +++++
 libcloud/compute/drivers/rimuhosting.py | 13 +++----------
 2 files changed, 8 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/libcloud/blob/dff5c531/CHANGES.rst
----------------------------------------------------------------------
diff --git a/CHANGES.rst b/CHANGES.rst
index 4ce3855..2870bc7 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -193,6 +193,11 @@ Compute
   (GITHUB-301)
   [Csaba Hoch]
 
+- Fix bug in RimuHosting driver which caused driver not to work when the
+  provider returned compressed (gzip'ed) response.
+  (LIBCLOUD-569, GITHUB-303)
+  [amastracci]
+
 Storage
 ~~~~~~~
 

http://git-wip-us.apache.org/repos/asf/libcloud/blob/dff5c531/libcloud/compute/drivers/rimuhosting.py
----------------------------------------------------------------------
diff --git a/libcloud/compute/drivers/rimuhosting.py b/libcloud/compute/drivers/rimuhosting.py
index edb344b..4c6b0e1 100644
--- a/libcloud/compute/drivers/rimuhosting.py
+++ b/libcloud/compute/drivers/rimuhosting.py
@@ -43,16 +43,9 @@ class RimuHostingException(Exception):
 
 
 class RimuHostingResponse(JsonResponse):
-    def __init__(self, response, connection):
-        self.body = response.read()
-        self.status = response.status
-        self.headers = dict(response.getheaders())
-        self.error = response.reason
-        self.connection = connection
-
-        if self.success():
-            self.object = self.parse_body()
-
+    """
+    Response Class for RimuHosting driver
+    """
     def success(self):
         if self.status == 403:
             raise InvalidCredsError()


Mime
View raw message