libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LIBCLOUD-569) RimuhostingResponseClass is unnecessarily overloaded.
Date Sun, 01 Jun 2014 19:29:01 GMT

    [ https://issues.apache.org/jira/browse/LIBCLOUD-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015068#comment-14015068
] 

ASF GitHub Bot commented on LIBCLOUD-569:
-----------------------------------------

GitHub user amastracci opened a pull request:

    https://github.com/apache/libcloud/pull/303

    [LIBCLOUD-569] Removing the overloaded constructor from the rimuhosting ...

    ...base class.
    
    Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress
function resuuulting in a MalformedResponseError. All functionality in overloaded constructor
already existed in the base clase.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Pertino/libcloud trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/303.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #303
    
----
commit feb5a8e85012ea9f78f9baf8455a154a49430a63
Author: amastracci <amastracci@pertino.com>
Date:   2014-06-01T19:22:28Z

    [LIBCLOUD-569] Removing the overloaded constructor from the rimuhosting base class.
    
    Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress
function resuuulting in a MalformedResponseError. All functionality in overloaded constructor
already existed in the base clase.

----


> RimuhostingResponseClass is unnecessarily overloaded.
> -----------------------------------------------------
>
>                 Key: LIBCLOUD-569
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-569
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>    Affects Versions: 0.14.0-beta3
>         Environment: Tested on Mac OSX and Ubuntu 13.10 using libcloud 0.14.1
>            Reporter: dustin oberloh
>            Priority: Critical
>              Labels: easyfix
>
> Response not decompressed due to no call to response base class constructor. What the
Rimu response class is doing already occurs in the base class. 
> Patch is inbound.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message