libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Phreedom <...@git.apache.org>
Subject [GitHub] libcloud pull request: [LIBCLOUD-614] multiple bugfixes and improv...
Date Thu, 18 Sep 2014 07:53:03 GMT
GitHub user Phreedom opened a pull request:

    https://github.com/apache/libcloud/pull/360

    [LIBCLOUD-614] multiple bugfixes and improvements to GCE

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Phreedom/libcloud nixops2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/360.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #360
    
----
commit 7911570004292991b8579d3ba5190dd393b5b8c3
Author: Evgeny Egorochkin <phreedom@yandex.ru>
Date:   2014-06-30T14:12:35Z

    GCE: healthcheck: add description param to ex_create_healthcheck(); targetpool: multiple
bugfixes
    
    Fix #1:
    
    targetpool = driver.ex_get_targetpool('tpname')
    targetpool.add_node(node)
    node.destroy() # targetpool still contains the node
    targetpool = driver.ex_get_targetpool('tpname')
        # targetpool.nodes contains node uri string (in addition to possible other node objects)
        # as produced by _to_targetpool because the node is in the pool but is destroyed
    targetpool.remove_node(node) # raises an exception, removes the node nevertheless.
    
    Expected behavior: remove the node, return true
    
    Fix #2:
    targetpool.add(node)
    targetpool.add(node)
        # targetpool.nodes contains 2 copies of node
        # actual targetpool resource on the GCE side doesn't contain 2 copies
    
    Expected behavior: no duplicates in targetpool.nodes, the node list matches GCE side
    
    Fix/Improvement #3:
    Allow specifying nodes by fully-qualified node uri in add_node and remove_node.
    
    if tp.nodes:
      tp.remove_node(tp.nodes[0]) # fails if the node in the list doesn't exist
    
    exoected behavior: should be able to remove any node from the list
    
    GCE allows adding non-existent nodes to the targetpool and doesn't automatically
    remove nodes from the pool if you delete them. libcloud should support doing the same.

commit d84a823c95a782253053af4782e4966006ff51bc
Author: Evgeny Egorochkin <phreedom@yandex.ru>
Date:   2014-06-30T21:50:02Z

    GCE: fix ex_targetpool_add_healthcheck and ex_targetpool_remove_healthcheck.
    
    The requests were malformed and thus did nothing.

commit 5beec36d660d3859b3e0cb7f4b925defcea2c832
Author: Evgeny Egorochkin <phreedom@yandex.ru>
Date:   2014-07-01T03:41:42Z

    GCE: add a parameter to ex_create_address to promote specific ephemeral addresses to static
ones.

commit 49de63c0db55fb094dbbc3079887d5f7665b0426
Author: Evgeny Egorochkin <phreedom@yandex.ru>
Date:   2014-07-02T03:50:26Z

    GCE: add description parameter to ex_create_forwarding_rule, improve tests; fix documentation
and test fixtures for health checks

commit b457589b1043ace20890d515774c7729905323d1
Author: Evgeny Egorochkin <phreedom@yandex.ru>
Date:   2014-07-02T08:00:21Z

    GCE: fix creating a forwarding rule with a static IP

commit bcafb9b65b857ae20c13bada99ca3f84543efd48
Author: Evgeny Egorochkin <phreedom@yandex.ru>
Date:   2014-07-02T20:52:18Z

    GCE: ex_create_firewall: allow creation og firewalls with sourceRanges = [], preserve
behavior for sourceRanges = None, preserve default value.
    
    GCE documentation states that firewall allows traffic
    if it matches either sourceRanges or sourceTags values.
    Thus, sourceRanges = [] is a valid parameter value.
    
    Although it would be better to simply set ["0.0.0.0/0"]
    as the default, for minimal API breakage, None value is
    still supported.

commit 784427f549829a00d551e3468184a708420ad1ec
Author: Evgeny Egorochkin <phreedom@yandex.ru>
Date:   2014-07-08T23:57:44Z

    GCE: fix parameter name for protocol in ex_create_forwarding_rule

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message