libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Itxaka <...@git.apache.org>
Subject [GitHub] libcloud pull request: adds ex_security_group_ids to ec2 in order ...
Date Sat, 11 Oct 2014 23:25:55 GMT
GitHub user Itxaka opened a pull request:

    https://github.com/apache/libcloud/pull/373

    adds ex_security_group_ids to ec2 in order to be able to launch nodes with security groups
on a VPC

    Due to amazon having a different param for the security groups on an instance launched
on a VPC and libcloud already supports VPCs (ex_subnet) this is the piece is missing to support
the security groups on a VPC node
    
    - adds a ex_security_group_ids kwarg which is a list of security group ids
    - checks for the existence of ex_subnet if ex_security_group_ids is called, as it depends
on it to make sense
    - adds a test to see if the params are being constructed correctly
    
    EC2 API page: http://docs.aws.amazon.com/AWSEC2/latest/APIReference/ApiReference-query-RunInstances.html
    ```
    SecurityGroupId.n
    One or more security group IDs. You can create a security group using CreateSecurityGroup.
    Type: String
    Default: Amazon EC2 uses the default security group.
    Required: No
    ```
    ```
    SecurityGroup.n
    [EC2-Classic, default VPC] One or more security group names. For a nondefault VPC, you
must use SecurityGroupId.n.
    Type: String
    Default: Amazon EC2 uses the default security group.
    Required: No
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Itxaka/libcloud add_security_group_ids_for_vpc_on_ec2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #373
    
----
commit c3f501df1f3d0b36f80e5487765a1f8b8df5a4fd
Author: Itxaka Serrano <itxaka.serrano@virdata.com>
Date:   2014-10-11T23:05:42Z

    ads ex_security_group_ids to ec2 in order to be able to launch nodes with security groups
on a VPC

commit 228a5c9bbe2594945a53bf55964ab620af65338f
Author: Itxaka Serrano <itxaka.serrano@virdata.com>
Date:   2014-10-11T23:23:44Z

    Use a subnet so the test works as expected

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message