libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franckcuny <...@git.apache.org>
Subject [GitHub] libcloud pull request: Google Cloud DNS
Date Mon, 20 Oct 2014 14:55:26 GMT
GitHub user franckcuny opened a pull request:

    https://github.com/apache/libcloud/pull/378

    Google Cloud DNS

    This CL fix a couple of bugs for the Google Cloud DNS' API, and handle the error code
'alreadyExists' as a 'ResourceExistsError'.
    
    cc @erjohnso 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/franckcuny/libcloud google_dns

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/378.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #378
    
----
commit 02aa8ee15b7fd7d186bff51b73de7861aff35808
Author: Franck Cuny <franckcuny@gmail.com>
Date:   2014-10-20T05:44:01Z

    Support CONFLICT response for Google Cloud's API
    
    If the status code for a call to the Google Cloud's API is 409 (CONFLICT), and
    the code of the error is 'alreadyExists', consider the resource as already
    existing and create the correct error.

commit 02d2dce7dd081812bede09927bc8c7a01088f5fc
Author: Franck Cuny <franckcuny@gmail.com>
Date:   2014-10-20T05:46:10Z

    The default ttl for Google Cloud's API is 0.
    
    The default can't be `None' since we're calling `int' on the value of ttl.

commit 0812eabba3dd199f564713bf67baa04e52eb3d2b
Author: Franck Cuny <franckcuny@gmail.com>
Date:   2014-10-20T05:47:40Z

    The 3rd argument for GoogleDNSConnection is secure, not scope.

commit 7f1e6b790513f887cfb2f7ebbfcc0d32e412d390
Author: Franck Cuny <franckcuny@gmail.com>
Date:   2014-10-20T14:53:21Z

    Reformat the code for pep8

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message