libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henk Slaaf (JIRA)" <>
Subject [jira] [Created] (LIBCLOUD-664) EC2 driver breaks contract with base driver in `list_volume_snapshots`
Date Thu, 12 Feb 2015 13:31:11 GMT
Henk Slaaf created LIBCLOUD-664:

             Summary: EC2 driver breaks contract with base driver in `list_volume_snapshots`
                 Key: LIBCLOUD-664
             Project: Libcloud
          Issue Type: Bug
            Reporter: Henk Slaaf
            Priority: Minor

The base driver has the following definition for `list_volume_snapshots`:

def list_volume_snapshots(self, volume):
        List snapshots for a storage volume.
        :rtype: ``list`` of :class:`VolumeSnapshot`
        raise NotImplementedError(
            'list_volume_snapshots not implemented for this driver')

This function is volume-centric and should return all snapshots for the given Volume.

In contrast, EC2 has the following, which is snapshot-centric and returns only the given snapshot.

    def list_volume_snapshots(self, snapshot):
        return self.list_snapshots(snapshot)

We should change this to both be volume-centric. In its current form, this function is identical
to list_snapshots and thus redundant.

This message was sent by Atlassian JIRA

View raw message