libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgogoulos <...@git.apache.org>
Subject [GitHub] libcloud pull request: list images does not break in case of inval...
Date Mon, 09 Feb 2015 14:00:07 GMT
GitHub user mgogoulos opened a pull request:

    https://github.com/apache/libcloud/pull/447

    list images does not break in case of invalid OS image types

    Make sure that list_images will not break if one of the IMAGE_PROJECTS keys  (OS image
types) changes in future. Right now if you run list_images with an invalid project name, the
connection.request_path is not  restored after the exception is run, so all requests that
follow will be invalid. 
    
    ```
    from libcloud.compute.providers import get_driver; from libcloud.compute.types import
Provider; driver = get_driver('gce')
    
    c = driver('email', 'key_path', project='name')
    
    c.list_images(ex_project='centos-cloudX')
    InvalidRequestError
    
    c.list_nodes()
    InvalidRequestError
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mgogoulos/libcloud GCE_IMAGES

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/447.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #447
    
----
commit 3d72cb7dc8efce8411974ad0ee553dace7f2d2a5
Author: Markos Gogoulos <mgogoulos@mist.io>
Date:   2015-02-09T13:46:21Z

    list images does not break in case of invalid OS image types

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message