libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LIBCLOUD-749) CloudStack: bugs in the method ex_authorize_security_group_ingress
Date Tue, 15 Sep 2015 21:53:46 GMT

    [ https://issues.apache.org/jira/browse/LIBCLOUD-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746334#comment-14746334
] 

ASF GitHub Bot commented on LIBCLOUD-749:
-----------------------------------------

GitHub user schaubl opened a pull request:

    https://github.com/apache/libcloud/pull/580

    [LIBCLOUD-749] CloudStack: fixed method ex_authorize_security_group_ingress

    Corresponding ticket in the issue tracker: [LIBCLOUD-749](https://issues.apache.org/jira/browse/LIBCLOUD-749)
    
    This PR fixes the following bugs:
    - The docstring doesn't match parameters of the method.
    - Only `ICMP` and `TCP` is allowed even if the doc of the parameter `protocol` mention
`TCP` and `UDP`.
    - Moreover `ICMP` cannot be used because there is no way to specify the two required parameters
`icmptype` and `icmpcode`.
    - The parameter `endport` is not used if it's defined.
    - The return type is not a `list` but a `dict`.
    - The unit test doesn't use parameters in the correct order.
    
    This PR also does the following changes:
    - Improve the docstring to be a bit more detailed (the previous one comes from the official
Apache CloudStack documentation).
    - Add a `kwargs` to allow to provide extra parameters defined in the API and in the docstring.
    - Improve the unit test.
    - Add support for other protocols like `AH`, `GRE` and `ESP` which are available on some
Cloud like Exoscale.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/schaubl/libcloud LIBCLOUD-749_cloudstack-fixed-ex_authorize_security_group_ingress

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/580.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #580
    
----
commit 84699dc524e57ac40de2b5eca5a92cfcee6cbc01
Author: lionel <lionel@sixsq.com>
Date:   2015-09-15T21:39:15Z

    [LIBCLOUD-749] CloudStack: fixed method ex_authorize_security_group_ingress

----


> CloudStack: bugs in the method ex_authorize_security_group_ingress
> ------------------------------------------------------------------
>
>                 Key: LIBCLOUD-749
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-749
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>         Environment: CloudStack compute driver
>            Reporter: L. Schaub
>              Labels: Bug, CloudStack, Improvement, SecurityGroups
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The method ex_authorize_security_group_ingress contains some bugs:
> - The docstring doesn't match parameters of the method.
> - Only ICMP and TCP is allowed even if the doc of the parameter "protocol" mention TCP
and UDP.
> - Moreover ICMP cannot be used because there is no way to specify the two required parameters
"icmptype" and "icmpcode".
> - The parameter endport is not used if it's defined.
> - The return type is not a list but a dict.
> - The unit test doesn't use parameters in the correct order.
> So I created a patch which aims to fix these bugs and also try to do the following:
> - Improve the docstring to be a bit more detailed (the previous one comes from the official
Apache CloudStack documentation).
> - Add a kwargs to allow to provide extra parameters defined in the API and in the docstring.
> - Improve the unit test.
> - Add support for other protocols like AH, GRE, ESP which are available on some Cloud
like Exoscale.
> I will provide the patch as a Pull Request in GitHub.
> Regards



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message