libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From crunk1 <...@git.apache.org>
Subject [GitHub] libcloud pull request: GoogleStorageDriver can now use either our ...
Date Fri, 13 Nov 2015 23:09:47 GMT
GitHub user crunk1 opened a pull request:

    https://github.com/apache/libcloud/pull/633

    GoogleStorageDriver can now use either our S3 authentication or other…

    … Cloud OAuth2 authentication methods.
    
    GoogleBaseConnection allows for a GCS_S3 auth type now, but does not handle creating the
S3 HMAC header. GoogleBaseConnection still handles OAuth2  for GCE, IA, and SA auth types.
    
    GoogleStorageConnection contains the logic for creating an S3 HMAC auth header and the
logic for switching between the oauth2 auth or the S3 HMAC auth.
    
    Changed an InvalidContainerNameError to ContainerError in S3 create_container. The exception
was being raised on ANY 400 error, which can be returned for things other than an invalid
name. In other words, the exception was a misnomer.
    
    Added tests for new logic.
    
    Did other minor cleanup.
    
    Tests run:
    Some manual tests putting, getting, and deleting objects/buckets. I used a Service Account,
Installed App creds, and S3 interoperability creds.
    libcloud.test.common.test_google
    libcloud.test.compute.test_gce (to make sure changes to the GoogleBaseConnection didn't
break it)
    libcloud.test.storage.test_google_storage
    libcloud.test.storage.test_s3

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/crunk1/libcloud trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/633.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #633
    
----
commit 860b7c29c9f7eb56eda65e24da5a42e8b9f6f335
Author: Scott Crunkleton <crunkleton@google.com>
Date:   2015-10-30T23:44:32Z

    GoogleStorageDriver can now use either our S3 authentication or other Cloud OAuth2 authentication
methods.
    
    GoogleBaseConnection allows for a GCS_S3 auth type now, but does not handle creating the
S3 HMAC header. GoogleBaseConnection still handles OAuth2  for GCE, IA, and SA auth types.
    
    GoogleStorageConnection contains the logic for creating an S3 HMAC auth header and the
logic for switching between the oauth2 auth or the S3 HMAC auth.
    
    Changed an InvalidContainerNameError to ContainerError in S3 create_container. The exception
was being raised on ANY 400 error, which can be returned for things other than an invalid
name. In other words, the exception was a misnomer.
    
    Added tests for new logic.
    
    Did other minor cleanup.
    
    Tests run:
    Some manual tests putting, getting, and deleting objects/buckets. I used a Service Account,
Installed App creds, and S3 interoperability creds.
    libcloud.test.common.test_google
    libcloud.test.compute.test_gce (to make sure changes to the GoogleBaseConnection didn't
break it)
    libcloud.test.storage.test_google_storage
    libcloud.test.storage.test_s3

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message