libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LIBCLOUD-800) GoogleStorageDriver marking everything as application/json MIME-type.
Date Tue, 02 Feb 2016 00:24:39 GMT

    [ https://issues.apache.org/jira/browse/LIBCLOUD-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127325#comment-15127325
] 

ASF GitHub Bot commented on LIBCLOUD-800:
-----------------------------------------

GitHub user crunk1 opened a pull request:

    https://github.com/apache/libcloud/pull/689

    Addressing https://issues.apache.org/jira/browse/LIBCLOUD-800. Changed

    GoogleStorageConnection to not inherit from GoogleBaseConnection. Separated OAuth2 credential
management from GoogleBaseConnection. This allows both GoogleBaseConnection and GoogleStorageConnection
to use OAuth2. Modified and ran tests to validate changes.
    
    Also ran a few manual tests using GoogleStorageDriver and GCENodeDriver. GoogleStorageDriver
works with either OAuth2 credentials or S3 Interoperability credentials. Tested setting the
mime type on an uploaded GCS object.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/crunk1/libcloud trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/689.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #689
    
----
commit 536d027a08b0a72a63d8ef8af58f84325c352054
Author: Scott Crunkleton <crunkleton@google.com>
Date:   2016-02-02T00:03:44Z

    Addressing https://issues.apache.org/jira/browse/LIBCLOUD-800. Changed
    GoogleStorageConnection to not inherit from GoogleBaseConnection.
    Separated OAuth2 credential management from GoogleBaseConnection. This
    allows both GoogleBaseConnection and GoogleStorageConnection to use
    OAuth2. Modified and ran tests to validate changes.
    
    Also ran a few manual tests.

----


> GoogleStorageDriver marking everything as application/json MIME-type.
> ---------------------------------------------------------------------
>
>                 Key: LIBCLOUD-800
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-800
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Storage
>            Reporter: Scott Crunkleton
>            Priority: Minor
>
> This started when I changed the GoogleStorageConnection to inherit from GoogleBaseConnection,
which always uses application/json.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message