libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LIBCLOUD-713) GCE driver list_sizes does not return the price
Date Sat, 30 Apr 2016 13:54:12 GMT

    [ https://issues.apache.org/jira/browse/LIBCLOUD-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265317#comment-15265317
] 

ASF GitHub Bot commented on LIBCLOUD-713:
-----------------------------------------

GitHub user erjohnso opened a pull request:

    https://github.com/apache/libcloud/pull/779

    [LIBCLOUD-713] fix missing pricing data

    ## [LIBCLOUD-713] fix missing pricing data
    
    ### Description
    
    Fixes [LIBCLOUD-713](https://issues.apache.org/jira/browse/LIBCLOUD-713) where pricing
data for GCE was not being referenced correctly.
    
    ### Status
    
    - done, ready for selfie
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [x] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/erjohnso/libcloud gce_pricing

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/779.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #779
    
----
commit 48f2264964fa76c2b98d7d98dc28c6f0064f1a89
Author: Eric Johnson <erjohnso@google.com>
Date:   2016-04-30T13:47:01Z

    [google compute] fix missing pricing data

----


> GCE driver list_sizes does not return the price
> -----------------------------------------------
>
>                 Key: LIBCLOUD-713
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-713
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>    Affects Versions: 0.15.1
>            Reporter: Webinav
>            Assignee: Eric Johnson
>            Priority: Minor
>             Fix For: 0.15.1
>
>
> I am using libcloud 0.15.1 and trying to pullout the pricing details for GCE
> I noticed that there is a KeyError exception thrown which causes the price to be set
as None
> Driver: GCE
> File: gce.py
> API: _to_node_size()
> Snippet:
>         try:
>             price = self._get_size_price(size_id=machine_type['name'])
>         except KeyError:
>             price = None



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message