libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From erjohnso <...@git.apache.org>
Subject [GitHub] libcloud pull request: [google compute] Add support for subnetwork...
Date Tue, 03 May 2016 17:35:19 GMT
GitHub user erjohnso opened a pull request:

    https://github.com/apache/libcloud/pull/780

    [google compute] Add support for subnetworks

    ## Adding support subnetworks to GCE driver
    
    ### Description
    
    This PR adds support Google Compute Engine's subnetworks feature[1].  When this feature
was introduced, Google suggested users begin using automatically allocated regional subnetworks
versus a single global network. The GCE driver predates subnetworks, so the default is still
set to create **legacy** networks, even though this is no longer recommended.
    
    Subnetworks are a necessary prerequisite for other GCE networking features that will be
added to libcloud shortly.
    
    [1] https://cloud.google.com/compute/docs/subnetworks
    
    ### Status
    
    I intend to leave this PR open for community review for 7 days and will merge it to trunk
if there are no outstanding issues on 10-May-2016.
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [x] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/erjohnso/libcloud gce_subnetworks

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/780.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #780
    
----
commit cd051d436c659d8490bbb56f98caf06fc64ee8a0
Author: Eric Johnson <erjohnso@google.com>
Date:   2016-05-03T17:23:35Z

    [google compute] Add support for subnetworks

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message