libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lawrencellui-dd <...@git.apache.org>
Subject [GitHub] libcloud pull request: added node.extra['networking_type'] to desc...
Date Thu, 05 May 2016 22:50:37 GMT
GitHub user lawrencellui-dd opened a pull request:

    https://github.com/apache/libcloud/pull/782

    added node.extra['networking_type'] to describe the MCP version of a …

    ## Adds MCP type to nodes.extra
    
    ### Description
    
    Adds NodeLocation.extra['networking_type'] so that you can tell if its an MCP2 or MCP1
site.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
    
    …given location

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lawrencellui-dd/libcloud mcp_type_info_in_location

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/782.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #782
    
----
commit b3d8a7bf005f39844189d6b5c7288666fe1f5c22
Author: Lawrence Lui <lawrence.lui@itaas.dimensiondata.com>
Date:   2016-05-05T22:47:53Z

    added node.extra['networking_type'] to describe the MCP version of a given location

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message