libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From erjohnso <...@git.apache.org>
Subject [GitHub] libcloud pull request: [google compute] preliminary support for GC...
Date Tue, 10 May 2016 22:15:14 GMT
GitHub user erjohnso opened a pull request:

    https://github.com/apache/libcloud/pull/784

    [google compute] preliminary support for GCE beta API

    ## [google compute] Preliminary support for GCE beta API
    
    ### Description
    
    Google Compute Engine serves both a 'v1' and 'beta' API. Over time the 'beta' API will
be promoted to 'v2'. New GCE features that are additive and backwards compatible are added
to 'v1'. But some features are only surfaced in 'beta'.
    
    This PR is the start of building in support for GCE users to specify which version of
the API to use. The provided `demos/gce_demo.py` script has been tested against the 'beta'
API and works as expected. However, unittest fixtures are heavily tied to 'v1' and will require
more work to create a more robust 'v1' and 'beta' set of tests. For the time being, this PR
provides the basics for adding new `test_beta_` methods, but otherwise assumes the use of
'v1'.
    
    Follow up PRs will begin addressing support for both API versions.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
    
    FYI @supertom 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/erjohnso/libcloud beta_api

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/784.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #784
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message