libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anthonys...@apache.org
Subject [1/2] libcloud git commit: auroradns: The 'extra' parameter in update_record() should be optional
Date Tue, 05 Jul 2016 09:18:04 GMT
Repository: libcloud
Updated Branches:
  refs/heads/trunk 6f695001b -> 664bb3402


auroradns: The 'extra' parameter in update_record() should be optional

In base update_record() is defined with extra=None but this was not properly
done in the Aurora DNS driver.

Update the method signature so that it matches the base DNS driver of libcloud.

Closes #830


Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/320862a3
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/320862a3
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/320862a3

Branch: refs/heads/trunk
Commit: 320862a3242d456c5058e72b98dd4fab6ae699d8
Parents: 6f69500
Author: Wido den Hollander <wido@widodh.nl>
Authored: Sat Jul 2 19:03:35 2016 +0200
Committer: Anthony Shaw <anthonyshaw@apache.org>
Committed: Tue Jul 5 19:16:33 2016 +1000

----------------------------------------------------------------------
 libcloud/dns/drivers/auroradns.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/libcloud/blob/320862a3/libcloud/dns/drivers/auroradns.py
----------------------------------------------------------------------
diff --git a/libcloud/dns/drivers/auroradns.py b/libcloud/dns/drivers/auroradns.py
index 23e7f36..f0991f4 100644
--- a/libcloud/dns/drivers/auroradns.py
+++ b/libcloud/dns/drivers/auroradns.py
@@ -338,7 +338,7 @@ class AuroraDNSDriver(DNSDriver):
                                 method='DELETE')
         return True
 
-    def update_record(self, record, name, type, data, extra):
+    def update_record(self, record, name, type, data, extra=None):
         rdata = {}
 
         if name is not None:


Mime
View raw message