libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lmorfitt <...@git.apache.org>
Subject [GitHub] libcloud pull request #839: [LIBCLOUD-833] and [LIBCLOUD-834](workaround)
Date Mon, 11 Jul 2016 12:59:34 GMT
GitHub user lmorfitt opened a pull request:

    https://github.com/apache/libcloud/pull/839

    [LIBCLOUD-833] and [LIBCLOUD-834](workaround)

    ## Changes Title (replace this with a logical title for your changes)
    
    ### Description
    
    [LIBCLOUD-833] - The AWS China region requires V4 authentication. Set the auth version
to v4 allowing the region to function.
    
     [LIBCLOUD-834](workaround) - With V4 auth enabled the upload_via_stream function does
not work and fails with an "InvalidCreds" error. This work around disables the supports_s3_multipart_upload
section allow files to be uploaded to V4 regions.
    
    For more information on contributing, please see [Contributing](http://libcloud.readthedocs.org/en/latest/development.html#contributing)
    section of our documentation.
    
    ### Status
    
    Replace this: describe the PR status. Examples:
    -  ready for review
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lmorfitt/libcloud trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/839.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #839
    
----
commit ee0914d4cc5727542168eccc30cab5ce1204e9f7
Author: Luke Morfitt <lukemorfitt@lukes-macbook-pro.local>
Date:   2016-07-11T12:43:04Z

    China requrest v4 authentication

commit 62d0c4b824af8f47e872bf25570d5fd308c6d801
Author: Luke Morfitt <lukemorfitt@lukes-macbook-pro.local>
Date:   2016-07-11T12:46:22Z

    V4 authenticaion and multipart_upload currently fails with "InvalidCreds" error. Disabled
the upload using mutlipart uploads. Disabled upload_object_via_stream from using multipart
uploads which allows V4 Auth uploads to complete.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message