libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From The-Loeki <...@git.apache.org>
Subject [GitHub] libcloud pull request #846: [FIX] CloudStack: Values with wildcards will fai...
Date Mon, 01 Aug 2016 20:45:09 GMT
GitHub user The-Loeki opened a pull request:

    https://github.com/apache/libcloud/pull/846

    [FIX] CloudStack: Values with wildcards will fail signature validation

    ## Changes Title (replace this with a logical title for your changes)
    
    ### Description
    
    Replace this with the PR description (mention the changes you have made, why
    you have made them, provide some background and any references to the provider
    documentation if needed, etc.).
    
    For more information on contributing, please see [Contributing](http://libcloud.readthedocs.org/en/latest/development.html#contributing)
    section of our documentation.
    
    ### Status
    
    Replace this: describe the PR status. Examples:
    
    - work in progress
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
    
    Thanks to a small bug in the request signer the signature will be invalid for any request
with any value containing a wildcard.
    
    Identical to https://github.com/apache/cloudstack-cloudmonkey/commit/38b68fbe0bf9a4bea1836bba55be57928ef74cee

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/The-Loeki/libcloud patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/846.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #846
    
----
commit 54fdbd0c1b4872c22411e6d66fe42773c98c8ab5
Author: Ronald van Zantvoort <the-loeki@users.noreply.github.com>
Date:   2016-08-01T20:44:57Z

    [FIX] CloudStack: Values with wildcards will fail signature validation
    
    Thanks to a small bug in the request signer the signature will be invalid for any request
with any value containing a wildcard.
    
    Identical to https://github.com/apache/cloudstack-cloudmonkey/commit/38b68fbe0bf9a4bea1836bba55be57928ef74cee

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message