libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From foriegnbody <...@git.apache.org>
Subject [GitHub] libcloud pull request #849: Libcloud 845 delete tags
Date Tue, 09 Aug 2016 17:08:17 GMT
GitHub user foriegnbody opened a pull request:

    https://github.com/apache/libcloud/pull/849

    Libcloud 845 delete tags

    Support deleting tags without values
    
    ex_delete_tags won't delete a tag without the value - it passes 'None' as a string.
    
    Modified ex_delete_tags to check for None as a passed Value of a tag and if found don't
supply Tag.%d.Value to params (and on to EC2 API). See http://docs.aws.amazon.com/AWSEC2/latest/CommandLineReference/ApiReference-cmd-DeleteTags.html
For API Reference - Value is not required and if supplied must match for tag to be deleted.
By always passing a value, a tag cannot be deleted if you don't know it's value.
    
    
    Status: done, ready for review
    
    Checklist: 
    
    - [x ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/foriegnbody/libcloud LIBCLOUD_845_DELETE_TAGS

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/849.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #849
    
----
commit 1b18a7a084494755630483b07f9d77a0d56949f0
Author: Ian White <ianw@ians-imac.local>
Date:   2016-08-09T16:46:43Z

    [LIBCLOUD-845] check for None as tag value and just use tag name when deleting

commit 8bd8cd188c7716d33105010be449796f3ea2884f
Author: Ian White <ianw@ians-imac.local>
Date:   2016-08-09T17:06:49Z

    [LIBCLOUD-845] fixed code formatting

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message