libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamieH <...@git.apache.org>
Subject [GitHub] libcloud pull request #850: Fix a missing / in requests made by the DockerCo...
Date Tue, 09 Aug 2016 19:46:29 GMT
GitHub user JamieH opened a pull request:

    https://github.com/apache/libcloud/pull/850

    Fix a missing / in requests made by the DockerContainerDriver

    ## Fix a missing / in requests made by the DockerContainerDriver
    
    ### Description
    
    Following the examples provided by the documentation would result in a "400 Bad Request"
error due to the fact that the requests didn't begin with a '/' for example:
    
    ```
    GET v1.24/images/json HTTP/1.1
    ```
    would result in a 400 Bad Request error, but:
    
    ```
    GET /v1.24/images/json HTTP/1.1
    ```
    
    does not.
    
    ### Status
    
    done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JamieH/libcloud patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/850.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #850
    
----
commit 66fa5e31604f782000d0096704f51ff20798fbf1
Author: Jamie Hankins <jamieh@users.noreply.github.com>
Date:   2016-08-09T19:44:32Z

    Fix a missing / in requests made by the DockerContainerDriver 
    
    Following the examples provided by the documentation would result in a "400 Bad Request"
error due to the fact that the requests didn't begin with a '/' for example:
    
    GET v1.24/images/json HTTP/1.1
    
    would result in a 400 Bad Request error, but:
    
    GET /v1.24/images/json HTTP/1.1
    
    does not.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message