libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From steve-gregory <...@git.apache.org>
Subject [GitHub] libcloud pull request #853: Fix NameError - 'body' is not defined
Date Fri, 19 Aug 2016 22:23:07 GMT
GitHub user steve-gregory opened a pull request:

    https://github.com/apache/libcloud/pull/853

    Fix NameError - 'body' is not defined

    ## Fix the NameError caused by missing 'body' variable
    
    ### Description
    
    Small change to add, but would be a big help. When a response from Openstack fails, the
missing 'body' variable caused an uncaught exception. I remedied this by adding the body variable,
similar to what was done above the else statement.
    
    ### Status
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iPlantCollaborativeOpenSource/libcloud patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/853.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #853
    
----
commit ddb884c674fb54a5d513bac950b4ca2c639a3d9d
Author: Steve Gregory <contact@steve-gregory.com>
Date:   2016-08-19T22:20:19Z

    Fix NameError - 'body' is not defined

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message