libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From relaxdiego <...@git.apache.org>
Subject [GitHub] libcloud pull request #858: Backup bug fix
Date Fri, 16 Sep 2016 18:24:47 GMT
GitHub user relaxdiego opened a pull request:

    https://github.com/apache/libcloud/pull/858

    Backup bug fix

    ### Description
    
    This replaces PR #781.
    
    Currently if a backup doesn't exists on a target, we return None, since we're using this
value in getting a backup target we end up throwing an error
    Also after linting, it looks like paginated responses were erroring out if paginated responses
were empty.
    
    ### Status
    
    ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [X] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/relaxdiego/libcloud backup_bug_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/858.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #858
    
----
commit 418b4e02a05d2e857748aa30708a319b6d84fd8d
Author: Jeffrey Dunham <jeffrey.a.dunham@gmail.com>
Date:   2016-05-03T23:26:51Z

    Bug fix on None type for return

commit 5fb0b924a66b9473fa490d7e74643fead9b0ec00
Author: Jeffrey Dunham <jeffrey.a.dunham@gmail.com>
Date:   2016-05-05T20:26:15Z

    Fixing bug in paginated calls caused after linting, added tests to cover cases

commit 3c57360ea3d98c174449ae2614d33000334da231
Author: Jeffrey Dunham <jeffrey.a.dunham@gmail.com>
Date:   2016-05-05T20:31:26Z

    Removing a print statement

commit 7fed326a2a0cc33bd73568a1cb76b239a51db582
Author: Jeffrey Dunham <jeffrey.a.dunham@gmail.com>
Date:   2016-05-05T21:57:04Z

    Fixing copypasta assetId/assetName

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message