libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From allardhoeve <...@git.apache.org>
Subject [GitHub] libcloud pull request #864: Fix case where node does not exist on OpenStack
Date Fri, 23 Sep 2016 08:49:45 GMT
GitHub user allardhoeve opened a pull request:

    https://github.com/apache/libcloud/pull/864

    Fix case where node does not exist on OpenStack

    ## Fix OpenStack `ex_get_node_details` for non-existing nodes
    
    ### Description
    
        Fix case where node does not exist on OpenStack
        
          - Add case where the node does not exist on OS
          - Fix code that tries to return None if the node does not exist
    
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [x] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ByteInternet/libcloud os-stop-node

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/864.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #864
    
----
commit e9b088620639b921d66fcc920c6611a4e406c3f0
Author: Allard Hoeve <allardhoeve@gmail.com>
Date:   2016-09-23T08:46:23Z

    Fix case where node does not exist on OpenStack
    
      - Add case where the node does not exist on OS
      - Fix code that tries to return None if the node does not exist

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message