libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From allardhoeve <...@git.apache.org>
Subject [GitHub] libcloud pull request #866: OS create_snapshot posts optional keywords only ...
Date Fri, 23 Sep 2016 10:24:44 GMT
GitHub user allardhoeve opened a pull request:

    https://github.com/apache/libcloud/pull/866

    OS create_snapshot posts optional keywords only when needed

    ## OS create_snapshot_volume does not post optional keywords if they are None
    
    ### Description
    
    On never OpenStacks, posting None for `name` or `description` will return a 400 Bad Request.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ByteInternet/libcloud fix-os-create-snapshot

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/866.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #866
    
----
commit e6e33b72604e337bf5317dbea573703cbdc3b983
Author: Allard Hoeve <allardhoeve@gmail.com>
Date:   2016-09-23T10:23:52Z

    OS create_snapshot posts optional keywords only when needed

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message