libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From allardhoeve <...@git.apache.org>
Subject [GitHub] libcloud pull request #867: StorageVolumeSnapshot now has a .name
Date Fri, 23 Sep 2016 14:32:28 GMT
GitHub user allardhoeve opened a pull request:

    https://github.com/apache/libcloud/pull/867

    StorageVolumeSnapshot now has a .name

    ## StorageVolumeSnapshot now has an attribute .name
    
    ### Description
    
    StorageVolumeSnapshot is the last object that normally has a name, that does not actually
have an attribute `.name`. This PR adds that attribute. It leaves the `.extra['name']` though,
for backwards-compatibility.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [x] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ByteInternet/libcloud snapshot-has-name

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/867.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #867
    
----
commit 785ec4e2e7122871471a1112acb8eeb47cadcd88
Author: Allard Hoeve <allardhoeve@gmail.com>
Date:   2016-09-23T14:30:57Z

    StorageVolumeSnapshot now has a .name

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message