libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From matfin <...@git.apache.org>
Subject [GitHub] libcloud pull request #938: [LIBCLOUD-873] Updated ProfitBricks Compute Driv...
Date Wed, 02 Nov 2016 09:18:28 GMT
GitHub user matfin opened a pull request:

    https://github.com/apache/libcloud/pull/938

    [LIBCLOUD-873] Updated ProfitBricks Compute Driver (REST api v3)

    ## Updating the ProfitBricks compute driver to work with the REST api (v3)
    
    ### Description
    
    This PR includes changes to the ProfitBricks compute driver to drop support for the old
SOAP api (now end of life) and provide support for v3 of the REST api.
    
    All public operations provided by the new REST api are supported in this driver. 
    
    New test fixtures have been added and all tests have been amended.
    
    A change has been added to the libcloud/common/base.py file to ensure that a request that
returns with a HTTP status of 202 is not flagged as a failed request. Before this, only 200
and 201 were flagged as successful requests.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - Code linting for the compute driver implementation and the accompanying test file has
been completed using the ```flake8``` tool.
    
    - Documentation has been updated consisting of examples of using all core and extended
functionality specific to ProfitBricks. A demo file with instructions on creating two servers
has been put together and these will be published on the ProfitBricks community website.
    
    - All test fixtures for api calls have been added in JSON format, replacing the older
XML fixtures. All tests are passing.
    
    ### Summary of changes
    
    Refactoring the compute  driver to remove support for the EOL SOAP api and modifying api
calls to use the REST api (v3).
    
    Removing XML test fixtures and replacing them with JSON fixtures.
    
    Providing wrappers for all new functionality provided in v3 of the Cloud API.
    
    Addressing an issue in libcloud/common/base.py where a http status code of 202 would not
be flagged as a successful request.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StackPointCloud/libcloud feature/pb_api_v3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/938.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #938
    
----
commit bc9b0c839c1ecb2d13d0e8eafa7f17d3b5c1e6f2
Author: Matt Finucane <matfin@gmail.com>
Date:   2016-10-10T11:17:10Z

    [LIBCLOUD-873] Updated ProfitBricks Compute Driver (REST api v3)
    
    Refactoring the compute  driver to remove support for the EOL SOAP api and modifying api
calls to use the REST api (v3).
    
    Removing XML test fixtures and replacing them with JSON fixtures.
    
    Providing wrappers for all new functionality provided in v3 of the Cloud API.
    
    Addressing an issue in libcloud/common/base.py where a http status code of 202 would not
be flagged as a successful request.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message