libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From samuelchong <...@git.apache.org>
Subject [GitHub] libcloud pull request #940: Dimension Data - Enable api version
Date Tue, 08 Nov 2016 04:24:05 GMT
GitHub user samuelchong opened a pull request:

    https://github.com/apache/libcloud/pull/940

    Dimension Data - Enable api version

    ## Changes Title (replace this with a logical title for your changes)
    
    ### Description
    Allow specifying api version to use. such as 
    driver = cls('schong_platcaas', 'T3stst@r!', region='dd-au', api_version='2.4')
    if no api version is provided, it will use the default version (usually the latest).
    
    Validation is included to check for the oldest and latest version supported. 
    
    ### Status
    
    Replace this: describe the PR status. Examples:
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [X] Documentation
    - [X] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/samuelchong/libcloud enable_api_version

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/940.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #940
    
----
commit f4caab373b18e3c02cdfe3e4580cb03efb7a9199
Author: Samuel Chong <samuelchong1@gmail.com>
Date:   2016-11-03T00:10:07Z

    Enable specifying api version

commit 45fea8d5f4b7a8bb3147d79ceebc624f36200491
Author: Samuel Chong <samuelchong1@gmail.com>
Date:   2016-11-03T04:01:57Z

    update comment

commit 75111a446e8323df607c17703bfb4303eb966dde
Author: Samuel Chong <samuelchong1@gmail.com>
Date:   2016-11-08T04:16:38Z

    update variable names

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message