libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tetron <...@git.apache.org>
Subject [GitHub] libcloud pull request #968: Ensure that request_path is restored on exceptio...
Date Fri, 06 Jan 2017 15:12:02 GMT
GitHub user tetron opened a pull request:

    https://github.com/apache/libcloud/pull/968

    Ensure that request_path is restored on exception 

    ## Ensure that request_path is restored on exception 
    
    ### Description
    
    When requesting a GCE license, restore the request_path in a finally block.  Uses same
pattern as used in other parts of the driver.
    
    ### Status
    
    Ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/curoverse/libcloud gce_request_path_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/968.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #968
    
----
commit cb7508a590fce5e22199c646c9fdab9670c8014a
Author: Peter Amstutz <peter.amstutz@curoverse.com>
Date:   2017-01-06T15:10:04Z

    Ensure that request_path is restored on exception raise when requesting a license.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message