libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tonybaloney <...@git.apache.org>
Subject [GitHub] libcloud pull request #971: fix issue where port is not propagated down to c...
Date Mon, 09 Jan 2017 06:21:00 GMT
GitHub user tonybaloney opened a pull request:

    https://github.com/apache/libcloud/pull/971

    fix issue where port is not propagated down to connection URL

    Noticed that a custom port does not roll down properly to the connection class.
    
    Also, there is still an outstanding issue that unless the port is 443, the connection
will be assumed as plain HTTP.
    
    E.g. setting port as 9999 but Secure=True will still issue a plain HTTP connection

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tonybaloney/libcloud fix_port_propagation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/971.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #971
    
----
commit 6261cc5fbb436283df4bb4265f01d4eeabb6c80e
Author: Anthony Shaw <anthonyshaw@apache.org>
Date:   2017-01-09T06:19:34Z

    fix issue where port is not propagated down to connection URL

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message