libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tonybaloney <...@git.apache.org>
Subject [GitHub] libcloud pull request #973: Fix access to httplib.HTTPResponse class from Ra...
Date Tue, 10 Jan 2017 09:57:29 GMT
GitHub user tonybaloney opened a pull request:

    https://github.com/apache/libcloud/pull/973

    Fix access to httplib.HTTPResponse class from RawResponses

    I've noticed that some drivers rely on access to a `httplib.HTTPResponse` object as a
property of `RawResponse`. This was updated in #728 to the requests response class, which
would, in turn, break a few implementations.
    
    To avoid backward compatibility issues, this introduces a proxy class with `HTTPResponse`
methods and properties and tests to validate access.
    
    None of the existing unit tests would have caught this behaviour since the response classes
are mocked. This issue was caught in #970 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tonybaloney/libcloud fix_raw_read_method

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/973.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #973
    
----
commit d979b922360fb64f35b4bf4d75e5c9ff69694911
Author: Anthony Shaw <anthonyshaw@apache.org>
Date:   2017-01-10T05:55:09Z

    add test to show it doesn't work as it used to

commit 2fcd275bac3732c3a7d0e25286403dcc9a784ec6
Author: Anthony Shaw <anthonyshaw@apache.org>
Date:   2017-01-10T09:54:10Z

    add httplib.HTTPResponse proxy to the response property of the RawResponse cls instead
of exposing the requests' response class directly

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message