libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zacharya19 <...@git.apache.org>
Subject [GitHub] libcloud pull request #975: Gcloud: allow delete instances from managed grou...
Date Thu, 12 Jan 2017 18:56:35 GMT
GitHub user zacharya19 opened a pull request:

    https://github.com/apache/libcloud/pull/975

    Gcloud: allow delete instances from managed group

    ## Gcloud: allow delete instances from managed group
    
    ### Description
    
    Google compute API now allow to delete instances from instance group manager, as you can
see here:
    https://cloud.google.com/compute/docs/reference/latest/instanceGroupManagers/deleteInstances
    I added this option in gce driver.
    Not sure about how to create a test for that, will be great to get some help here.
    
    ### Status
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zacharya19/libcloud GcloudDeleteInstances

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/975.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #975
    
----
commit 7bcd4f1a242ec0cd26063e6a6cfcd0e64e8515c8
Author: zacharya19 <zacharya19@gmail.com>
Date:   2017-01-12T18:40:15Z

    Gcloud: allow delete instances from managed group

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message