libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tonybaloney <...@git.apache.org>
Subject [GitHub] libcloud pull request #976: Refactoring LibcloudConnection and Connection cl...
Date Fri, 13 Jan 2017 02:11:49 GMT
GitHub user tonybaloney opened a pull request:

    https://github.com/apache/libcloud/pull/976

    Refactoring LibcloudConnection and Connection classes from feedback

    Issues Raised:
    
    - Use URLJoin instead of `''.join` : https://github.com/apache/libcloud/pull/923#discussion_r95320130
raised by @allardhoeve 
    - Create a test to ensure creating Connection instances with a trailing / and then using
request with a method with a leading / does not create malformed URL requests
    - Make allow_redirects configurable  (but true by default?) https://github.com/apache/libcloud/pull/923#discussion_r95320171
@allardhoeve 
    - Move verification logic into property in LibcloudConnection https://github.com/apache/libcloud/pull/923#discussion_r95319749
    - Fix if/else in hash buffer code https://github.com/apache/libcloud/pull/923#discussion_r95324871

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tonybaloney/libcloud connection_refactoring

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/976.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #976
    
----
commit e02a8f0e3f8af56dfc64c547c4c44b15250b447d
Author: Anthony Shaw <anthonyshaw@apache.org>
Date:   2017-01-13T02:07:05Z

    fix a bug where creating a connection from URL would not work when request actions start
with /. Urlparse instead of ''.join

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message