libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LIBCLOUD-906) Public IP not assigned when creating NIC on Azure ARM
Date Thu, 23 Mar 2017 15:24:41 GMT

    [ https://issues.apache.org/jira/browse/LIBCLOUD-906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938563#comment-15938563
] 

ASF GitHub Bot commented on LIBCLOUD-906:
-----------------------------------------

GitHub user ripa1993 opened a pull request:

    https://github.com/apache/libcloud/pull/1013

    [LIBCLOUD-906] Fix Public IP not assigned when creating NIC on Azure ARM

    ## Fix Public IP not assigned when creating NIC on Azure ARM
    
    ### Description
    
    This fixes the wrong use of `public_ip` in `ex_create_network_interface` in `AzureNodeDriver`.
The problem was the wrong access to the `data` dictionary when inserting the request for a
public ip to be assigned to the NIC that is going to be created
    
    ### Status
    done, ready for review
    
    ### Checklist (tick everything that applies)
    
    (just a line of code changes)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ripa1993/libcloud 906_azure-arm-public-ip

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1013.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1013
    
----
commit 219734792a89a7bef3e314dea3fc245a4752ce27
Author: ripa1993 <simone.ripamonti.1993@gmail.com>
Date:   2017-03-23T15:11:21Z

    [LIBCLOUD-906] Fix Public IP not assigned when creating NIC on Azure ARM

----


> Public IP not assigned when creating NIC on Azure ARM
> -----------------------------------------------------
>
>                 Key: LIBCLOUD-906
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-906
>             Project: Libcloud
>          Issue Type: Bug
>            Reporter: Simone Ripamonti
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message