libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LIBCLOUD-921) For Docker Driver: insecure (http) connection results in crash
Date Wed, 28 Jun 2017 10:09:00 GMT

    [ https://issues.apache.org/jira/browse/LIBCLOUD-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066273#comment-16066273
] 

ASF GitHub Bot commented on LIBCLOUD-921:
-----------------------------------------

GitHub user gargpankaj83 opened a pull request:

    https://github.com/apache/libcloud/pull/1082

    libcloud-921: aligning the function arguments with the signature

    #LIBCLOUD-921 
    
    Docker Container Driver uses ConnectionUserAndKey as the ConnectionCls. However, on using
the insecure Docker Engine, username passed is None. This results in mis-alignment of the
function signature and the arguments being passed.
    
    try/catch statement is required to handle the MockHttp class during the tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gargpankaj83/libcloud libcloud-921/insecure-connection

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1082.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1082
    
----
commit 8af72d9a9f1e3e59187e6c568eb1a5faec1eee63
Author: Pankaj Garg <garg.pankaj83@gmail.com>
Date:   2017-06-28T10:05:05Z

    libcloud-921: aligning the function arguments with the function signature

----


> For Docker Driver: insecure (http) connection results in crash
> --------------------------------------------------------------
>
>                 Key: LIBCLOUD-921
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-921
>             Project: Libcloud
>          Issue Type: Bug
>            Reporter: Pankaj Garg
>
> Container Driver: Docker
> Method: libcloud/common/base.py (BaseDriver.__init__)
> In case of insecure connection when secret key is not passed, the list of arguments and
the function signature will mis-match and result in error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message